This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($compile):remove controllerAs requirement #15106
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the controllerAs requirement when binding a directive to a controller
|
I didn't look at the tests, but there is more to be done to ensure the feature works. |
3 tasks
|
Closing in favor of #15110 (which is more complete). @austinoneil, btw, it is a good idea to comment on an issue when you start working on it, so we can coordinate better and avoid duplication of effort. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
Binding a directive to a controller without a
controllerAsproperty throws an error unnecessarily.What is the new behavior (if this is a feature change)?
Binding a directive to a controller without a
controllerAsproperty does not throw an error.Does this PR introduce a breaking change?
no
Please check if the PR fulfills these requirements
Other information:
Remove the controllerAs requirement when binding a directive to a
controller